reject tarball writes with no destinations #1534
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Kaniko accepts a
--tarPath
arg to write out to a tarball. I mistakenly passed this without a--destination
and ended up with a tarball with only amanifest.json
containingnull
.I opened google/go-containerregistry#887 to fix the issue in go-containerregistry (calculating a manifest without refs doesn't make much sense), but we should also check for this on the kaniko side with kaniko specific details to help users do the right thing.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
There are no tests for the tarball write path as far as I can tell. Adding unit/integration tests to test this one check would be a substantial lift.
See the contribution guide for more details.
Reviewer Notes
Release Notes
Describe any changes here so maintainer can include it in the release notes, or delete this block.